From 3829a9b66c0363e1bfa9f9e2513bb2c58cbcb18f Mon Sep 17 00:00:00 2001 From: Christoph Berg Date: Sun, 22 Oct 2017 19:16:24 +0200 Subject: [PATCH] The control file does not contain enableIntTimes anymore PG10 gets rid of controlData->enableIntTimes, remove it in pg_filedump as well. We could add try adding #ifs to still show it for older major versions, but given that pg_filedump is cross-version compatible for dumping the recent major's control files except for this change, it seems more prudent to simply remove it. We don't show other fields like float4ByVal either, and pg_controldata is a better tool for control file inspection anyway, so keep the logic in pg_filedump simple. --- pg_filedump.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pg_filedump.c b/pg_filedump.c index ccc7eba..f900eda 100644 --- a/pg_filedump.c +++ b/pg_filedump.c @@ -1616,8 +1616,7 @@ FormatControl() " XLOG Segment Size: %u\n" " Maximum Identifier Length: %u\n" " Maximum Index Keys: %u\n" - " TOAST Chunk Size: %u\n" - " Date and Time Type Storage: %s\n\n", + " TOAST Chunk Size: %u\n\n", EQ_CRC32C(crcLocal, controlData->crc) ? "Correct" : "Not Correct", controlData->pg_control_version, @@ -1646,9 +1645,7 @@ FormatControl() controlData->xlog_seg_size, controlData->nameDataLen, controlData->indexMaxKeys, - controlData->toast_max_chunk_size, - (controlData->enableIntTimes ? - "64 bit Integers" : "Floating Point")); + controlData->toast_max_chunk_size); } else {