From 1f784089a672ff7a4c244465dfa9276ffc33487f Mon Sep 17 00:00:00 2001
From: Nathan Bossart <bossartn@amazon.com>
Date: Thu, 2 Mar 2017 02:58:41 +0000
Subject: [PATCH] Added regression testing for --no-superuser-check option.

---
 bin/pg_repack.c             |  2 +-
 regress/expected/repack.out | 17 +++++++++++++++++
 regress/sql/repack.sql      | 13 +++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/bin/pg_repack.c b/bin/pg_repack.c
index b4ceaf1..36ceed8 100644
--- a/bin/pg_repack.c
+++ b/bin/pg_repack.c
@@ -277,7 +277,7 @@ static pgut_option options[] =
 	{ 'B', 'Z', "no-analyze", &analyze },
 	{ 'i', 'j', "jobs", &jobs },
 	{ 'b', 'D', "no-kill-backend", &no_kill_backend },
-  { 'b', 'k', "no-superuser-check", &no_superuser_check },
+	{ 'b', 'k', "no-superuser-check", &no_superuser_check },
 	{ 0 },
 };
 
diff --git a/regress/expected/repack.out b/regress/expected/repack.out
index 9359731..17e3666 100644
--- a/regress/expected/repack.out
+++ b/regress/expected/repack.out
@@ -386,3 +386,20 @@ ERROR: cannot repack specific schema(s) in all databases
 --
 \! pg_repack --dbname=contrib_regression --table=tbl_cluster --no-kill-backend
 INFO: repacking table "tbl_cluster"
+--
+-- no superuser check
+--
+DROP ROLE IF EXISTS nosuper;
+CREATE ROLE nosuper WITH LOGIN;
+-- => OK
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --no-superuser-check
+INFO: repacking table "tbl_cluster"
+-- => ERROR
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --username=nosuper
+ERROR: pg_repack failed with error: You must be a superuser to use pg_repack
+-- => ERROR
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --username=nosuper --no-superuser-check
+ERROR: pg_repack failed with error: ERROR:  permission denied for schema repack
+LINE 1: select repack.version(), repack.version_sql()
+               ^
+DROP ROLE IF EXISTS nosuper;
diff --git a/regress/sql/repack.sql b/regress/sql/repack.sql
index 3bcd38e..e613d63 100644
--- a/regress/sql/repack.sql
+++ b/regress/sql/repack.sql
@@ -232,3 +232,16 @@ CREATE TABLE test_schema2.tbl2 (id INTEGER PRIMARY KEY);
 -- don't kill backend
 --
 \! pg_repack --dbname=contrib_regression --table=tbl_cluster --no-kill-backend
+
+--
+-- no superuser check
+--
+DROP ROLE IF EXISTS nosuper;
+CREATE ROLE nosuper WITH LOGIN;
+-- => OK
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --no-superuser-check
+-- => ERROR
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --username=nosuper
+-- => ERROR
+\! pg_repack --dbname=contrib_regression --table=tbl_cluster --username=nosuper --no-superuser-check
+DROP ROLE IF EXISTS nosuper;