farrokhi/pg_repack
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Change trigger name from a_repack_trigger to repack_trigger.

Browse Source 
In AFTER trigger context, since triggered tuple is not changed by
any other triggers we can call it just repack_trigger.
This commit is contained in:
Masahiko Sawada
2017-01-24 14:09:05 +09:00
parent d83ee3d6a0
commit 375f03c0c3
7 changed files with 33 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
doc/pg_repack.rst
View File

@ -362,7 +362,7 @@ ERROR: query failed: ERROR: column "col" does not exist
Specify existing columns.
WARNING: the table "tbl" already has a trigger called a_repack_trigger
WARNING: the table "tbl" already has a trigger called repack_trigger
The trigger was probably installed during a previous attempt to run
pg_repack on the table which was interrupted and for some reason failed
to clean up the temporary objects.
@ -370,16 +370,6 @@ WARNING: the table "tbl" already has a trigger called a_repack_trigger
You can remove all the temporary objects by dropping and re-creating the
extension: see the installation_ section for the details.
WARNING: trigger "trg" conflicting on table "tbl"
The target table has a trigger whose name follows ``a_repack_trigger``
in alphabetical order.
The ``a_repack_trigger`` should be the first AFTER trigger to fire.
Please rename your trigger so that it sorts alphabetically before
pg_repack's one; you can use::
ALTER TRIGGER aaa_my_trigger ON sometable RENAME TO bbb_my_trigger;
ERROR: Another pg_repack command may be running on the table. Please try again
later.

22
doc/pg_repack_jp.rst
View File

@ -661,17 +661,17 @@ ERROR: query failed: ERROR: column "col" does not exist
.. class:: diag
WARNING: the table "tbl" already has a trigger called a_repack_trigger
WARNING: the table "tbl" already has a trigger called repack_trigger
以前に実行したが何らかの理由で中断したか、あるいは失敗したpg_repackコマンドにより、
対象テーブルにpg_repackが利用するトリガが残存している場合に表示されます。
pg_repackを一度削除して、再度登録することで、こうした一時オブジェクトを削除できます。
`インストール`_ を参照してください。
.. WARNING: trigger "trg" conflicting on table "tbl"
The target table has a trigger whose name follows ``a_repack_trigger``
The target table has a trigger whose name follows ``repack_trigger``
in alphabetical order.
The ``a_repack_trigger`` should be the first AFTER trigger to fire.
The ``repack_trigger`` should be the first AFTER trigger to fire.
Please rename your trigger so that it sorts alphabetically before
pg_repack's one; you can use::
@ -679,22 +679,6 @@ WARNING: the table "tbl" already has a trigger called a_repack_trigger
.. class:: diag
WARNING: trigger "trg" conflicting on table "tbl"
対象のテーブルが、pg_repackが利用する ``a_repack_trigger`` という名前のトリガ
よりもアルファベット順で前になるような名前のトリガを持っている場合に表示されます。
``a_repack_trigger`` トリガは最初に実行されるAFTERトリガになる必要があります。
該当のトリガ名称を変更してください。::
ALTER TRIGGER aaa_my_trigger ON sometable RENAME TO bbb_my_trigger;
.. ERROR: Another pg_repack command may be running on the table. Please try again
later.
There is a chance of deadlock when two concurrent pg_repack commands are run
on the same table. So, try to run the command after some time.
.. class:: diag
ERROR: Another pg_repack command may be running on the table. Please try again
同じテーブルに複数のpg_repackが同時に実行されている場合に表示されます。
これはデッドロックを引き起こす可能性があるため、片方のpg_repackが終了するのを