From 4eb1cef99e2ce8f5b246158d9ecb3643f580bea4 Mon Sep 17 00:00:00 2001 From: schmiddy Date: Sat, 24 May 2014 00:09:03 -0400 Subject: [PATCH] Make the 'repacking index ...' message be displayed for indexes-only repacks (not just when in dry-run mode). --- bin/pg_repack.c | 4 +--- regress/expected/repack.out | 3 +++ regress/sql/repack.sql | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/bin/pg_repack.c b/bin/pg_repack.c index 63f711b..2979a00 100644 --- a/bin/pg_repack.c +++ b/bin/pg_repack.c @@ -1683,6 +1683,7 @@ repack_table_indexes(PGresult *index_details) "WHERE pgc.relname = 'index_%u' " "AND nsp.nspname = $1", index); params[0] = schema_name; + elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index); res = execute(sql.data, 1, params); if (PQresultStatus(res) != PGRES_TUPLES_OK) { @@ -1705,10 +1706,7 @@ repack_table_indexes(PGresult *index_details) } if (dryrun) - { - elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index); continue; - } params[0] = utoa(index, buffer[0]); res = execute("SELECT repack.repack_indexdef($1, $2, $3, true)", 3, diff --git a/regress/expected/repack.out b/regress/expected/repack.out index 30f2688..84b0073 100644 --- a/regress/expected/repack.out +++ b/regress/expected/repack.out @@ -323,6 +323,9 @@ INFO: repacking table "tbl_nn_uk" \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk INFO: repacking table "tbl_pk_uk" -- => OK +\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes +INFO: repacking indexes of "tbl_pk_uk" +-- => OK \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk WARNING: relation "tbl_nn_puk" must have a primary key or not-null unique keys -- => WARNING diff --git a/regress/sql/repack.sql b/regress/sql/repack.sql index c46ed4d..4bc5f9c 100644 --- a/regress/sql/repack.sql +++ b/regress/sql/repack.sql @@ -185,6 +185,8 @@ CREATE UNIQUE INDEX tbl_nn_puk_pcol1_idx ON tbl_nn_puk(col1) WHERE col1 < 10; -- => OK \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk -- => OK +\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes +-- => OK \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk -- => WARNING