From 70cc5769c9c7c5f7b8c09887d00458878e6d0623 Mon Sep 17 00:00:00 2001 From: Josh Kupershmidt Date: Fri, 29 May 2015 21:18:45 -0400 Subject: [PATCH] Remember to free repacked_indexes. --- bin/pg_repack.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/bin/pg_repack.c b/bin/pg_repack.c index d6f1de6..dcd4340 100644 --- a/bin/pg_repack.c +++ b/bin/pg_repack.c @@ -1867,8 +1867,10 @@ repack_table_indexes(PGresult *index_details) getstr(index_details, i, 0)); } - if (dryrun) - return true; + if (dryrun) { + ret = true; + goto done; + } /* If we did not successfully repack any indexes, e.g. because of some * error affecting every CREATE INDEX attempt, don't waste time with @@ -1911,7 +1913,6 @@ repack_table_indexes(PGresult *index_details) ret = true; drop_idx: - CLEARPGRES(res); resetStringInfo(&sql); initStringInfo(&sql_drop); #if PG_VERSION_NUM < 90200 @@ -1935,6 +1936,11 @@ drop_idx: } termStringInfo(&sql_drop); termStringInfo(&sql); + +done: + CLEARPGRES(res); + free(repacked_indexes); + return ret; }