farrokhi/pg_repack
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Imply --no-order for non-clustered tables

Browse Source 
--no-order can still be specified to VACUUM FULL a clustered tables
(not so useful I guess...)

Fixes issue #6.
This commit is contained in:
Daniele Varrazzo
2013-04-17 01:42:22 +01:00
parent 1d62d8d0c5
commit 8efbd9e1c6
4 changed files with 41 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
bin/pg_repack.c
View File

@ -521,27 +521,28 @@ repack_one_database(const char *orderby, char *errbuf, size_t errsize)
resetStringInfo(&sql);
if (!orderby)
{
/* CLUSTER mode */
if (ckey == NULL)
if (ckey != NULL)
{
ereport(WARNING,
(errcode(E_PG_COMMAND),
errmsg("relation \"%s\" has no cluster key", table.target_name)));
continue;
/* CLUSTER mode */
appendStringInfo(&sql, "%s ORDER BY %s", create_table, ckey);
table.create_table = sql.data;
}
else
{
/* VACUUM FULL mode (non-clustered tables) */
table.create_table = create_table;
}
appendStringInfo(&sql, "%s ORDER BY %s", create_table, ckey);
table.create_table = sql.data;
}
else if (!orderby[0])
{
/* VACUUM FULL mode */
table.create_table = create_table;
/* VACUUM FULL mode (for clustered tables too) */
table.create_table = create_table;
}
else
{
/* User specified ORDER BY */
appendStringInfo(&sql, "%s ORDER BY %s", create_table, orderby);
table.create_table = sql.data;
table.create_table = sql.data;
}
table.sql_peek = getstr(res, i, c++);