farrokhi/pg_repack
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make the 'repacking index ...' message be displayed

Browse Source 
for indexes-only repacks (not just when in dry-run mode).
This commit is contained in:
schmiddy 2014-05-24 00:09:03 -04:00
parent 69aa4f741d
commit 4eb1cef99e
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bin/pg_repack.c
View File

@ -1683,6 +1683,7 @@ repack_table_indexes(PGresult *index_details)
"WHERE pgc.relname = 'index_%u' " "WHERE pgc.relname = 'index_%u' "
"AND nsp.nspname = $1", index); "AND nsp.nspname = $1", index);
params[0] = schema_name; params[0] = schema_name;
elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index);
res = execute(sql.data, 1, params); res = execute(sql.data, 1, params);
if (PQresultStatus(res) != PGRES_TUPLES_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
@ -1705,10 +1706,7 @@ repack_table_indexes(PGresult *index_details)
} }
if (dryrun) if (dryrun)
{
elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index);
continue; continue;
}
params[0] = utoa(index, buffer[0]); params[0] = utoa(index, buffer[0]);
res = execute("SELECT repack.repack_indexdef($1, $2, $3, true)", 3, res = execute("SELECT repack.repack_indexdef($1, $2, $3, true)", 3,

3
regress/expected/repack.out
View File

@ -323,6 +323,9 @@ INFO: repacking table "tbl_nn_uk"
\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk
INFO: repacking table "tbl_pk_uk" INFO: repacking table "tbl_pk_uk"
-- => OK -- => OK
\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes
INFO: repacking indexes of "tbl_pk_uk"
-- => OK
\! pg_repack --dbname=contrib_regression --table=tbl_nn_puk \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk
WARNING: relation "tbl_nn_puk" must have a primary key or not-null unique keys WARNING: relation "tbl_nn_puk" must have a primary key or not-null unique keys
-- => WARNING -- => WARNING

2
regress/sql/repack.sql
View File

@ -185,6 +185,8 @@ CREATE UNIQUE INDEX tbl_nn_puk_pcol1_idx ON tbl_nn_puk(col1) WHERE col1 < 10;
-- => OK -- => OK
\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk
-- => OK -- => OK
\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes
-- => OK
\! pg_repack --dbname=contrib_regression --table=tbl_nn_puk \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk
-- => WARNING -- => WARNING